Skip to content

fix: Possible NPE in initBiDi() #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2025
Merged

fix: Possible NPE in initBiDi() #2325

merged 4 commits into from
Aug 12, 2025

Conversation

panchenko
Copy link
Contributor

Change list

Make sure httpClientFactory in AppiumCommandExecutor is not null.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

version 9.5.0, code is like below

DesiredCapabilities capabilities = new DesiredCapabilities();
capabilities.setCapability("webSocketUrl", true);
driver = new AndroidDriver(AppiumClientConfig.defaultConfig().baseUri(URI.create(url)), capabilities);

throws

Exception in thread "main" java.lang.NullPointerException: 
Cannot invoke "org.openqa.selenium.remote.http.HttpClient$Factory.createClient(org.openqa.selenium.remote.http.ClientConfig)"
because the return value of "io.appium.java_client.remote.AppiumCommandExecutor.getHttpClientFactory()" is null
	at io.appium.java_client.AppiumDriver.initBiDi(AppiumDriver.java:423)
	at io.appium.java_client.AppiumDriver.startSession(AppiumDriver.java:344)
	at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:173)
	at io.appium.java_client.AppiumDriver.<init>(AppiumDriver.java:101)
	at io.appium.java_client.AppiumDriver.<init>(AppiumDriver.java:109)
	at io.appium.java_client.android.AndroidDriver.<init>(AndroidDriver.java:223)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@mykola-mokhnach mykola-mokhnach changed the title fix possible NPE in initBiDi() fix: Possible NPE in initBiDi() Aug 9, 2025
@mykola-mokhnach
Copy link
Contributor

Could you please address checkstyle issues: https://github.com/appium/java-client/actions/runs/16846955387/job/47729343352?pr=2325#step:6:436 ?

@mykola-mokhnach mykola-mokhnach merged commit 75ee094 into appium:master Aug 12, 2025
6 of 7 checks passed
@KazuCocoa KazuCocoa added the size:S contribution size: S label Sep 1, 2025
@KazuCocoa
Copy link
Member

Hi @panchenko, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget Awaiting requested review from SrinivasanTarget SrinivasanTarget is a code owner

@saikrishna321 saikrishna321 Awaiting requested review from saikrishna321 saikrishna321 is a code owner

@valfirst valfirst Awaiting requested review from valfirst valfirst is a code owner

Assignees

No one assigned

Labels

size:S contribution size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panchenko @mykola-mokhnach @KazuCocoa